fix: multipl session disconnects throwing #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://fix_multiple_disconnection--walletweb.review-wallet-web.5afe.dev |
iamacook
commented
Oct 18, 2023
Comment on lines
+144
to
+153
| const isUnsupportedChain = !currentEip155ChainIds.includes(newEip155ChainId) | ||
| const isNewSessionSafe = !currentEip155Accounts.includes(newEip155Account) | ||
|
|
||
| // Switching to unsupported chain | ||
| if (hasNewChainId) { | ||
| if (isUnsupportedChain) { | ||
| return this.disconnectSession(session) | ||
| } | ||
|
|
||
| // Add new account to the session namespace | ||
| if (hasNewAccount) { | ||
| // Add new Safe to the session namespace | ||
| if (isNewSessionSafe) { |
There was a problem hiding this comment.
These renames somehow didn't merge correctly before.
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report❌ An unexpected error occurred. For more details, check console
Test suite run failedFailed tests: 2/1010. Failed suites: 4/141.Report generated by 🧪jest coverage report action from ab82d11 |
katspaugh
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves multiple session disconnects throwing
How this PR fixes it
Session updated are now handled one after each other.
How to test it
Connect two DApps that support chain A but not chain B. Switch from chain A to chain B and observe no WC-related error.
Checklist