feat: block/warn about bridges accordingly #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://wc_bridge_warnings--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Oct 18, 2023
| @@ -0,0 +1,43 @@ | |||
| const DangerousBridges = [ | |||
There was a problem hiding this comment.
Naming-wise, there's nothing dangerous/risky about these bridges per se, it's just that they aren't smart contract account-friendly. Please find more specific, non-sensationalistic, names for the two arrays. And please move these lists (not the two functions below) to src/components/walletconnect/constants.ts.
katspaugh
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves blocks/warns of risky bridge use
How this PR fixes it
The usage of certain bridges are either blocked or warned about, requiring user acceptance according to our research.
How to test it
Open one of the bridges specified and observe either a blocked connection window, or a warning that needs to first be accepted.
Screenshots
Checklist