Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align all Popovers to header #2623

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: align all Popovers to header #2623

merged 1 commit into from
Oct 12, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves non-uniform alignments

How this PR fixes it

All Popovers in the header now aligned directly below the header.

How to test it

Open the notification, WC, account centre and network switcher popovers and observe them aligned below the header.

Screenshots

popover-alignment

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Oct 12, 2023
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Branch preview

✅ Deploy successful!

https://popover_alignment--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook merged commit 08c1c11 into nect Oct 12, 2023
7 of 10 checks passed
@iamacook iamacook deleted the popover-alignment branch October 12, 2023 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants