Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable 1-click safe create for social login #2620

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Oct 12, 2023

What it solves

Resolves #2458

How this PR fixes it

  • Disables Social Login when not on Gnosis Chain and shows an info text
  • Skips to the review screen on safe creation when using Social Login
  • Displays simplified relay sponsor view in review screen
  • Disables network selector when using Social Login

ToDos

  • Disable safe creation if no relays left

How to test it

  1. Open the welcome page
  2. Switch to an unsupported network
  3. Observe the Social Login is disabled with an info text
  4. Switch to Gnosis chain and log in via Google
  5. Observe the Network selector is disabled
  6. Enter the safe creation flow
  7. Observe jumping right to the review screen
  8. No execution method selector is shown and instead a simple message saying Free
  9. Disconnect from Google
  10. Connect via MM
  11. Network Selector should work
  12. Enter the safe creation
  13. First step of the safe creation should open

Screenshots

Screenshot 2023-10-12 at 10 47 18 Screenshot 2023-10-12 at 10 55 47

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Branch preview

✅ Deploy successful!

https://quick_safe_create--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to adjust the MPCLogin.test.tsx . You need to mock the currentChain to be on Gnosis Chain such that the buttons are enabled.
You could also add a test case for non supported networks to check that the button is disabled and the hint is shown.

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 small nits in the test. Otherwise LGTM!

@usame-algan usame-algan merged commit daf6bdb into web3authcoresdk Oct 12, 2023
7 checks passed
@usame-algan usame-algan deleted the quick-safe-create branch October 12, 2023 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants