fix: populate help section #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview⏳ Deploying a preview site... |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Oct 12, 2023
Comment on lines
62
to
65
| 'Connect a dApp by following the above steps', | ||
| `Ensure the dApp is connected to ${chain?.chainName ?? 'this chain'}`, | ||
| 'Initiate a transaction/signature request via the dApp', | ||
| 'Transact/sign as normal via the Safe', |
There was a problem hiding this comment.
Please exctract the hardcode to a const, you can use a replacement pattern for the chain name.
katspaugh
reviewed
Oct 12, 2023
Comment on lines
71
to
72
| <HintAccordion title="How do I connect to a dApp?" items={ConnectionSteps} /> | ||
| <HintAccordion title="How do I interact with a dApp?" items={InteractionSteps} /> |
There was a problem hiding this comment.
Please extract the hardcoded titles.
katspaugh
reviewed
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves missing WC help info
How this PR fixes it
The help regarding connection/interaction with a dApp has been added.
How to test it
Open the WC modal and observe the help information within the accordions. Hiding and showing them should work accordingly.
Screenshots
Checklist