Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: native WalletConnect styling #2617

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: native WalletConnect styling #2617

merged 1 commit into from
Oct 11, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Oct 11, 2023 •
edited
Loading

What it solves

Implements the design of native WalletConnect

How this PR fixes it

The implementation is now according to the design.

How to test it

Interact with WalletConnect and observe that it matches the design.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

Branch preview

❌ Deploy failed!

@iamacook
Copy link
Member Author

After discussion, I will merge this into the epic directly as preliminary tests are underway.

@iamacook iamacook marked this pull request as ready for review October 11, 2023 15:54
@iamacook iamacook merged commit 81de6da into nect Oct 11, 2023
3 of 8 checks passed
@iamacook iamacook deleted the native-wc-style branch October 11, 2023 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@iamacook iamacook

Labels
None yet
Projects
Web Squad
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iamacook