Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Seedless Onboarding]: Show Safe list sidebar button on welcome page #2609

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Part of #2452

How this PR fixes it

  • Displays the button to open the safe list sidebar if there are owned safes detected

How to test it

  1. Open the welcome page
  2. No button should be visible when not connected and there are no added safes
  3. Connect with a wallet that owns safes
  4. Observe the button appears and displays the number of owned safes + added safes

Screenshots

Screenshot 2023-10-10 at 13 21 11 Screenshot 2023-10-10 at 13 21 26

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Branch preview

✅ Deploy successful!

https://welcome_sidebar--walletweb.review-wallet-web.5afe.dev

@usame-algan
Copy link
Member Author

The total number is not 100% accurate as there can be duplications between owned and added safes. Imo not a big issue though since thats the number of safes the user can see in the sidebar.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@usame-algan usame-algan merged commit 6db3390 into web3authcoresdk Oct 10, 2023
5 of 7 checks passed
@usame-algan usame-algan deleted the welcome-sidebar branch October 10, 2023 14:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants