Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't show push notifications banner if wallet not conencted #2605

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

katspaugh
Copy link
Member

  • Don't track banner dismissal on enable all/customize.

The banner was previously shown regarless of whether you're connected which clashed with the onboard popup.

…n't track banner dismissal on enable all/customize
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Branch preview

✅ Deploy successful!

https://pushbanner--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh merged commit 854c7be into dev Oct 9, 2023
9 checks passed
@katspaugh katspaugh deleted the pushbanner branch October 9, 2023 10:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants