Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: track banner once #2598

Merged
merged 5 commits into from
Oct 6, 2023
Merged

fix: track banner once #2598

merged 5 commits into from
Oct 6, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Oct 6, 2023

What it solves

Resolves over-tracking of notification banner display

How this PR fixes it

Tracking of the notification banner now occurs whenever it is shown. It is done within a component to prevent complex caching of tracking. If the showBanner flag is true, the component renders and tracks.

How to test it

Open a Safe that has not been registered for notifications and observe only one "Display notification banner" event. If the banner is not dismissed, navigating back to the Safe should dispatch the tracking again. However, dismissing the banner should prevent any future tracking.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Branch preview

✅ Deploy successful!

https://track_banner_once--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

Looks good

The notification pop up is tracked once when a safe is added
Is tracked everytime that safe is opened if the pop up wasn't dissmissed before
After being dismissed there is no more tracking of the popup

@iamacook iamacook merged commit a1ea200 into dev Oct 6, 2023
9 checks passed
@iamacook iamacook deleted the track-banner-once branch October 6, 2023 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants