Fix: notifications popup: don't hide just one item #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
iamacook
approved these changes
Oct 2, 2023
katspaugh
commented
Oct 2, 2023
| @@ -1,7 +1,7 @@ | |||
| .txType { | |||
| display: flex; | |||
| align-items: center; | |||
| flex-wrap: wrap; | |||
| flex-wrap: nowrap; | |||
There was a problem hiding this comment.
Unrelated to notification, it fixes this:
|
So it seems that "1 other notification" will not show up anymore, it shows 5 notifications and if there are 6 it will show 4 and "2 more notifications" to display. Looks good to me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid hiding a single notification behind a collapsible box. It occupies exactly the same space.
Plus, the wording "1 other notifications" is wrong.
How to test