Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Cypress tests: address book and balance tests #2502

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

mike10ca
Copy link
Contributor

@mike10ca mike10ca commented Sep 8, 2023

What it solves

  • Refactoring Cypress tests: address book and balances tests

Resolves #2501

How this PR fixes it

  • Implement PO model
  • Move important values outside of tests into constants.js file

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Branch preview

✅ Deploy successful!

https://cypress_tests_refactor--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@mike10ca
Copy link
Contributor Author

mike10ca commented Sep 8, 2023

recheck

@mike10ca
Copy link
Contributor Author

mike10ca commented Sep 8, 2023

I have read the CLA Document and I hereby sign the CLA

@mike10ca mike10ca marked this pull request as ready for review September 8, 2023 15:08
@francovenica
Copy link
Contributor

Looks good. I like that we are going to have a more standarized structure for tests

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@katspaugh katspaugh merged commit 69e681b into dev Sep 11, 2023
9 checks passed
@katspaugh katspaugh deleted the cypress-tests-refactor branch September 11, 2023 06:13
@gitpoap-bot
Copy link

gitpoap-bot bot commented Sep 11, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Safe Contributor:

GitPOAP: 2023 Safe Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA Automation: Refactoring address book and balances tests
3 participants