Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add push notification tracking #2500

Merged
merged 3 commits into from
Sep 18, 2023
Merged

feat: add push notification tracking #2500

merged 3 commits into from
Sep 18, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Sep 7, 2023

What it solves

Adds cached tracking to push notifications

How this PR fixes it

Due to technical limitations and a desire to keep the service worker small, every notification that is shown/clicked increments a counter in a new notifications-tracking-database IndexedDB database. A tracking event is then dispatched for every count when the UI is next shown.

How to test it

  1. Ensure notifications are subscribed to and trigger one when the Safe is closed.
  2. Open the Safe UI and observe a tracking event, labelled correcty.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Branch preview

✅ Deploy successful!

https://firebase_tracking--walletweb.review-wallet-web.5afe.dev

@iamacook iamacook mentioned this pull request Sep 7, 2023
3 tasks
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge once the main PR is reviewed.

@francovenica
Copy link
Contributor

The notifications looks good. Let me know if it is merged in to the epic so I can be sure it work there as well

image

@iamacook iamacook merged commit a8ed67a into firebase Sep 18, 2023
6 of 7 checks passed
@iamacook iamacook deleted the firebase-tracking branch September 18, 2023 07:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants