Update default value for Relay Service URL #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
katspaugh
approved these changes
Sep 4, 2023
I was waiting for a confirmation on the production URLs but it seems that they can be updated as well. Do you prefer a separate PR or should I include the update on this one? |
|
This one pls |
Updates the default value set for `SAFE_RELAY_SERVICE_URL_STAGING` from `https://safe-client-nest.staging.5afe.dev/v1/relay` to `https://safe-client.staging.5afe.dev/v1/relay`
Updates the default value set for `NEXT_PUBLIC_SAFE_RELAY_SERVICE_URL_PRODUCTION` from `https://safe-client-nest.safe.global/v1/relay` to `https://safe-client.safe.global/v1/relay`
fmrsabino
force-pushed
the
update-relay-service-url-staging
branch
from
9805da6
to
03163bb
Compare
fmrsabino
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
The
-nestname in the domain name should not be used anymore and will be removed in the future. This PR updates the respective value to use the new supported URL.How this PR fixes it
SAFE_RELAY_SERVICE_URL_STAGINGfromhttps://safe-client-nest.staging.5afe.dev/v1/relaytohttps://safe-client.staging.5afe.dev/v1/relaySAFE_RELAY_SERVICE_URL_PRODUCTIONfromhttps://safe-client-nest.safe.global/v1/relaytohttps://safe-client.safe.global/v1/relayHow to test it
NA
Screenshots
NA
Checklist