Kaushik kc/notification list overflows the viewport in mobile #2469
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Thanks for the PR! Could you post a screenshot with actual notifications in the popup? |
| @@ -13,6 +13,13 @@ | |||
| border: 1px solid var(--color-border-light); | |||
| } | |||
|
|
|||
| @media only screen and (max-width: 470px) { | |||
There was a problem hiding this comment.
We are using MUI in this project and try to adhere to the default breakpoints as much as possible. In this case I would suggest to use the max-sm breakpoint which is 599.95px.
|
Here is the screenshot of the actual notifications in the popup
I have also added the MUI breakpoints to solve this. I have read the CLA Document and I hereby sign the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@KaushikKC can you check the diff? It says 1138 files changed. Looks like an OS formatting issue. |
|
It's not a formatting issue, the dev branch was rebased. |
KaushikKC
force-pushed
the
KaushikKC/Notification-list-overflows-the-viewport-in-mobile
branch
from
7f1c172
to
a348b2d
Compare
Yeah done |
|
There’s still some git issue. Actually Usame was right. Looks like the permissions of each file were changed. |
|
I've merged these changes here: e200a0e |
What it solves
Resolves #2446
How this PR fixes it
I have used the Css media query to adjust the width of the notification bar in the mobile screen
How to test it
open the site in the developer mode and view in different mobile width.
Screenshots
Checklist