-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Human-readable v2 #2465
Closed
Closed
feat: Human-readable v2 #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://human_readable_history--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
usame-algan
force-pushed
the
human-readable-history
branch
from
August 29, 2023 10:02
9f7f18c
to
e5afdd3
Compare
I've adjusted how we display WalletConnect txs as per @tschubotz's feedback: |
usame-algan
force-pushed
the
human-readable-history
branch
from
September 7, 2023 07:17
a8b1df5
to
911c6e1
Compare
usame-algan
force-pushed
the
human-readable-history
branch
from
September 7, 2023 07:18
911c6e1
to
7e29054
Compare
usame-algan
force-pushed
the
human-readable-history
branch
from
September 14, 2023 11:24
d0e7f09
to
b7ea591
Compare
usame-algan
force-pushed
the
human-readable-history
branch
from
September 14, 2023 12:45
b7ea591
to
30e2926
Compare
3 tasks
Closing this in favor of #2518 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on safe-global/safe-client-gateway#671
What it solves
Resolves #2449
ToDos
HumanDescription
component to parse structured data response from CGW once feat: Human readable v2 safe-client-gateway#671 is mergeduseTransactionType
,TxType
andTxInfo
and make sure they are still neededHow this PR fixes it
TxType
andTxInfo
as well as theuseTransactionType
hookHow to test
The changes in this PR affect the history, queue, pending txs in the dashboard and the confirm tx screen
/history
of a safeSend/Receive <amount> to/from <address/name>
Call multiSend <on contract name><via safe app name> with <x amount> actions
while the existance of contract name and safe app name is optional so it could also beCall multiSend with <x amount> actions
Call <method name> on <name/address>
Interact with <contract address>
Screenshots
Checklist