Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Human-readable v2 #2465

Closed
wants to merge 19 commits into from
Closed

feat: Human-readable v2 #2465

wants to merge 19 commits into from

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Aug 29, 2023

Depends on safe-global/safe-client-gateway#671

What it solves

Resolves #2449

ToDos

How this PR fixes it

  • Adjusts the history and queue layout to make room for longer descriptions by combining the type and info column
  • Removes now unused components TxType and TxInfo as well as the useTransactionType hook
  • Adjusts fallback descriptions as outlined here

How to test

The changes in this PR affect the history, queue, pending txs in the dashboard and the confirm tx screen

  1. Open /history of a safe
  2. Observe that there are only 4 columns now (nonce, description, date, status)
  3. Transfers are now in the format of Send/Receive <amount> to/from <address/name>
  4. Human Descriptions are more styled now e.g. ERC20 approvals or withdraws will highlighted amounts
  5. Multisends are now in the format of Call multiSend <on contract name><via safe app name> with <x amount> actions while the existance of contract name and safe app name is optional so it could also be Call multiSend with <x amount> actions
  6. If the method name of a transaction is known the description has the following format: Call <method name> on <name/address>
  7. If no method name is known the description has the following format: Interact with <contract address>

Screenshots

Screenshot 2023-09-08 at 13 24 57 Screenshot 2023-09-08 at 13 25 13 Screenshot 2023-09-08 at 13 25 28 Screenshot 2023-09-08 at 13 25 59

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Branch preview

✅ Deploy successful!

https://human_readable_history--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member

I've adjusted how we display WalletConnect txs as per @tschubotz's feedback:

Screenshot 2023-09-04 at 14 55 43

@usame-algan usame-algan changed the title PoC: Human-readable history feat: Human-readable v2 Sep 6, 2023
@usame-algan usame-algan marked this pull request as ready for review September 8, 2023 11:46
@usame-algan
Copy link
Member Author

Closing this in favor of #2518

@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
@katspaugh katspaugh deleted the human-readable-history branch December 13, 2023 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Human-readable descriptions v2
2 participants