Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selector reference warnings #2460

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix: selector reference warnings #2460

merged 1 commit into from
Aug 29, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves console warning/unnecessary re-renders

How this PR fixes it

If a selector returns a new reference, it should be memoised either manually or inside createSelector, etc. The following changes solved the console warning:

  • selectAllBatches no longer returns an empty array but the initialState.
  • selectHiddenTokensPerChain now leverages createSelector as it can return an empty array.

How to test it

  • Run the project locally and observe no console warnings.
  • Batching should work as expected.
  • Hiding/showing spam tokens should work as expected.

Screenshots

Console warning in question:

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Aug 28, 2023
@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Branch preview

✅ Deploy successful!

https://fix_selectors--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@francovenica
Copy link
Contributor

Looks good to me

I don't see the warning shown in the ticket description

Batch and hidding tokens works fine as well

@iamacook iamacook merged commit d37c03c into dev Aug 29, 2023
8 of 9 checks passed
@iamacook iamacook deleted the fix-selectors branch August 29, 2023 13:31
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants