Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves console warning/unnecessary re-renders
How this PR fixes it
If a selector returns a new reference, it should be memoised either manually or inside
createSelector
, etc. The following changes solved the console warning:selectAllBatches
no longer returns an empty array but theinitialState
.selectHiddenTokensPerChain
now leveragescreateSelector
as it can return an empty array.How to test it
Screenshots
Console warning in question:
Checklist