-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disabled batch sidebar buttons when not owner #2454
Conversation
Branch preview✅ Deploy successful! https://batch_sidebar_buttons--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
It looks good for non-owners and disconnected users, they see the buttons grayed out. I dissagree with the spending limit owners being able to use the feature. A person with an allowance cannot do any of this things: Put a transaction that use the allowance in a batch, nor confirm a batch since none of those listed tx will ever be a spending limit. So both actions "Add tx to batch" and "Confirm batch" cannot be used by a user with a spending limit |
Thanks for the thorough testing! I removed access to non-owner spending limit beneficaries in 4c9f083. |
Looks good now The non-owners with allowance cannot use the feature anymore. |
What it solves
Resolves #2404
How this PR fixes it
The batch sidebar buttons are now disabled if the user is not connected or not an owner.
How to test it
Disabled
As a non-owner open the sidebar and observe the disabled buttons with tooltip when a batch doesn't exists and when one does.
Enabled
As an owner or non-owner open the sidebar and observe the enabled buttons tooltip when a batch doesn't exists and when one does.
Screenshots
Checklist