Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype: tKey MPC integration #2445

Closed
wants to merge 25 commits into from
Closed

prototype: tKey MPC integration #2445

wants to merge 25 commits into from

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Aug 25, 2023

Prototype for tKey MPC integration

This is a second PR because the branch had to be renamed such that the PR deployment can be used with Google OAuth.

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

Branch preview

✅ Deploy successful!

https://tkeympc--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 2 total


[warning] react-hooks/exhaustive-deps

verifies the list of dependencies for Hooks like useEffect and similar


[warning] import/no-anonymous-default-export

Forbid anonymous values as default exports.


Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@orchidtexture
Copy link

Hi @schmanu, hope is ok to ask here, I wonder, why didn't you use the web3-onboard/web3auth module for social login?

@schmanu
Copy link
Member Author

schmanu commented Sep 21, 2023

Closing this in favor of #2534

@schmanu schmanu closed this Sep 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
@schmanu
Copy link
Member Author

schmanu commented Sep 21, 2023

Hi @schmanu, hope is ok to ask here, I wonder, why didn't you use the web3-onboard/web3auth module for social login?

Hey @orchidtexture,
we need a more low level integration as we want to enable other ecosystem partners to derive the same addresses from the same social logins.
We moved away from tKey MPC SDK to the MPC Core SDK in the latest PR.
It wraps a lot of needed logic and makes the integration already a lot simpler.

@katspaugh katspaugh deleted the tkeympc branch December 13, 2023 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants