fix: allow safe apps to disable off-chain signing

[schmanu]

What it solves

Resolves #2440

How this PR fixes it

Considers the safe signing settings when signing a message from safe apps.

How to test it

1. Use the eip1271 test dapp
2. disable off-chain signing
3. sign a message
4. Observe on-chain signature modal

Checklist

• I've tested the branch on mobile 📱
• I've documented how it affects the analytics (if at all) 📊
• I've written a unit/e2e test for it (if applicable) 🧑‍💻

[github-actions]

Branch preview

✅ Deploy successful!

https://fix_safe_setsettings--walletweb.review-wallet-web.5afe.dev

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[katspaugh]

@schmanu can you give an example of how a Safe App can toggle this? Or is it the user who should toggle it?

[schmanu]

@schmanu can you give an example for how a Safe App can toggle this? Or is it the user who should toggle it?

@katspaugh It can be toggled by a custom RPC call safe_setSettings.

[francovenica]

So the onchain/offchain works, in the sense that if you choose how the message must be signed in the eip app that's what you get in the web app

I still got a bunch of other issues that I'm not sure are related to the ticket, so I'd like to debug them in a call if possible.

The messages are not showing in the message tab after signing
Trying to sign with a 2nd owner in a safe 2/x is throwing errors

[schmanu]

@francovenica
I can reproduce those issues on staging CGW.
When I use the prod CGW this does not happen.
In staging I also do not see the proposed message in the messages tab at all.

[francovenica]

Yes. I tried the same and it seems something is wrong with the stg CGW. I posted a message for the infra team to see if something has changed in the past week.

Taking that aside the ticket is fine
The message is being proposed as offchain/onchain depending on the "Enable/Disable off chain signing" in the app itself

Made sure that the checkbox in Settings > Safe apps, that forces the message to be on chain no matter what still works as intended

Looks good to me.
I'll re check this ticket after having a response from Infra team

[katspaugh]

@francovenica can we merge this, or do you want to check it again?

[francovenica]

Give it a 2nd try now that the issue with the CGW was solved

Looks good, I can enable now the on-chian type of message signing in the app and it works fine. Off chain message signing still works fine and the settings in the app that forces on-chain type of singature also works fine as well.