Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: gas price in header #2413

Closed
wants to merge 2 commits into from
Closed

Feat: gas price in header #2413

wants to merge 2 commits into from

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Aug 16, 2023

What it solves

Allows the user to check the gas price quickly which is convenient when executing transactions.

Screenshot 2023-08-16 at 18 40 31

Todo

  • Cache the gas price between polls so that tx modals use the same value
  • Don't display it for chains where we use a fixed price (?)

@katspaugh katspaugh marked this pull request as draft August 16, 2023 16:12
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Branch preview

✅ Deploy successful!

https://gas--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh changed the base branch from feat/fixed-1559-gasprice to dev August 17, 2023 07:40
@katspaugh katspaugh closed this Aug 28, 2023
@katspaugh katspaugh deleted the gas branch August 28, 2023 08:11
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant