Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wallet icons in dark mode #2392

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Fix: wallet icons in dark mode #2392

merged 2 commits into from
Aug 17, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #2374

How this PR fixes it

I've replaced our custom white background on wallet buttons with a semi-transparent white, so that it works for both dark and light icons.

Screenshots

Screenshot 2023-08-14 at 15 45 18 Screenshot 2023-08-14 at 15 45 43

@katspaugh katspaugh requested a review from schmanu August 14, 2023 13:46
@github-actions
Copy link

github-actions bot commented Aug 14, 2023

Branch preview

✅ Deploy successful!

https://fix_onboard_css--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Aug 14, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

francovenica commented Aug 14, 2023

I see the squares that have the icon inside much darker than in the snapshots.
I tried in chrome, FF and Brave. Also I tried the branch locally and it looks all the same.
It wouldn't be that big of a deal but the Ledger icon is barely visible this way

image

@katspaugh
Copy link
Member Author

@francovenica I somehow pushed a non-final version, it should be fixed now.

@francovenica
Copy link
Contributor

LGTM now:

image

@katspaugh katspaugh merged commit 90a876e into dev Aug 17, 2023
7 checks passed
@katspaugh katspaugh deleted the fix-onboard-css branch August 17, 2023 06:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboardjs - The Trezor icon cannot be seen with Dark mode enabled
3 participants