Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove whatwg-fetch #2386

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Chore: remove whatwg-fetch #2386

merged 2 commits into from
Aug 11, 2023

Conversation

iamacook
Copy link
Member

What it solves

Removes unnecessary dependency

How this PR fixes it

whatwg-fetch has been uninstalled.

How to test it

Observe the tests passing.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Aug 11, 2023
@github-actions
Copy link

github-actions bot commented Aug 11, 2023

Branch preview

✅ Deploy successful!

https://remove_whatwg_fetch--walletweb.review-wallet-web.5afe.dev

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katspaugh katspaugh changed the title fix: remove whatwg-fetch Chore: remove whatwg-fetch Aug 11, 2023
@github-actions
Copy link

github-actions bot commented Aug 11, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whatwg-fetch is imported inside jest.setup.js. Have you tested if it works without?

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works without it. I also tested it locally with node v16 without issues running tests.

@iamacook
Copy link
Member Author

I'm going to merge this direcly as it is only test-related and the CI passes.

@iamacook iamacook merged commit 5cf25e9 into dev Aug 11, 2023
7 checks passed
@iamacook iamacook deleted the remove-whatwg-fetch branch August 11, 2023 11:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants