Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: extend the emoji set for eth addresses #2368

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix: extend the emoji set for eth addresses #2368

merged 1 commit into from
Aug 8, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Aug 8, 2023

What it solves

A follow-up on #2305.

As per early feedback, we can extend the emoji set a little bit to have less potential duplicates.

Here's the full set currently used:

😀😁😂😃😄😅😆😇😈😉😊😋😌😍😎😸😹😺😻😼😽🚀🚁🚂🚃☔☕🌰🌱🌲🌳🌴🌵🌶🌷🌸🌹🌺🌻🌼🌽🌾🌿🍀🍁🍂🍃🍄🍅🍆🍇🍈🍉🍊🍋🍌🍍🍎🍏🍐🍑🍒🍓🍔🍕🍖🍗🍘🍙🍚🍛🍜🍝🍞🍟🍠🍡🍢🍣🍤🍥🍦🍧🍨🍩🍪🍫🍬🍭🍮🍯🍰🍱🍲🍳🍴🍵🍶🍷🍸🍹🍺🍻🍼🍽🍾🍿🎀🎁🎂🎃🎄🎅🎆🎇🎈🎉🎊🎋🎌🎍🎎🎏🎐🎑🎒🎓🎠🎡🎢🎣🎤🎥🎦🎧🎨🎩🎪🎫🎬🎭🎮🎯🎰🎱🎲🎳🎴🎵🎶🎷🎸🎹🎺🎻🎼🎽🎾🎿🏀🏁🏂🏃🏄🏅🏆🏇🏈🏉🏊🐀🐁🐂🐃🐄🐅🐆🐇🐈🐉🐊🐋🐌🐍🐎🐏🐐🐑🐒🐓🐔🐕🐖🐗🐘🐙🐚🐛🐜🐝🐞🐟🐠🐡🐢🐣🐤🐥🐦🐧🐨🐩🐪

That's 424 different characters.

@katspaugh katspaugh requested a review from mmv08 August 8, 2023 13:37
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Branch preview

✅ Deploy successful!

https://emoji--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member Author

@francovenica I'm going to merge this to the RC as it's hard to test manually given the range of possible options.
There's an automated test that checks that the entire set is used.

@katspaugh katspaugh merged commit 3d2ba01 into dev Aug 8, 2023
5 of 7 checks passed
@katspaugh katspaugh deleted the emoji branch August 8, 2023 13:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants