Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: fix tx modal e2e test #2367

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Tests: fix tx modal e2e test #2367

merged 1 commit into from
Aug 11, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Fixes the tx-modal e2e test

How this PR fixes it

  • The safe app fixture immediately sent a transaction to the communicator which sometimes made the test fail because the manifest wasn't fully fetched yet. This adds a small delay there
  • Also removes the useSafeAppFromManifest hook inside AppFrame since we already use the hook in the parent so we can pass it as a prop instead

How to test it

  • Safe apps should still work
  • The tx-modal e2e test should not fail anymore

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Branch preview

✅ Deploy successful!

https://fix_tx_modals_e2e--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh changed the title fix: tx modal e2e test Tests: fix tx modal e2e test Aug 8, 2023
@francovenica
Copy link
Contributor

The Safe app test are not failing in the PR anymore, so it is ok.

@katspaugh katspaugh merged commit 68171a3 into dev Aug 11, 2023
7 checks passed
@katspaugh katspaugh deleted the fix-tx-modals-e2e branch August 11, 2023 06:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants