Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prevent an early redirect on the Safe Apps share page #2358

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Aug 7, 2023

What it solves

Resolves #2320

How this PR fixes it

It should wait for the client-side router to kick in before attempting a redirect.

How to test

Open this link:

https://fix_app_share--walletweb.review-wallet-web.5afe.dev/share/safe-app?appUrl=https%3A%2F%2Fsafe-apps.dev.5afe.dev%2Fdrain-safe&chain=gor

It should not redirect to the Dashboard.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Branch preview

✅ Deploy successful!

https://fix_app_share--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!appUrl || !validChain || !chain can be moved to a variable as it's used twice.

@katspaugh
Copy link
Member Author

Good idea but TypeScript no likey.

@francovenica
Copy link
Contributor

LGTM.
I had to use a safari emulator to reproduce the issue in ther first place since as you said chrome (and FF) didn't show the issue.
The url provided works fine.

@katspaugh katspaugh merged commit 425cf08 into dev Aug 8, 2023
7 checks passed
@katspaugh katspaugh deleted the fix-app-share branch August 8, 2023 05:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Safe Apps] Shared URL redirects to dashboard
3 participants