-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: sidebar links to queue if there are queued txs #2357
Conversation
Branch preview✅ Deploy successful! https://queue_redirect--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Have we considered how we can measure the success of this change? I think it could be confusing if the same button has 2 different behaviours without the user knowing i.e. expecting to go to the history but ending up in the queue and vice versa especially if both pages look very similar it could slow the user down more. |
Valid point, @usame-algan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a small unit test, that checks that this rerouting will trigger?
Otherwise it's one of the small features that might get lost in a refactor.
Other than that this looks good and I'll already approve :)
ESLint Summary View Full Report
Report generated by eslint-plus-action |
The main feature works fine, the redirection to queue when there is a tx there works fine, to the history tab otherwise. There is an issue with GA tho. Now visiting the tx history or queue triggers the /transaction/history or /queue event, but also there is an event for just "/transaction". |
d587946
to
a3a465a
Compare
@francovenica I've made the sidebar link itself change to either queue or history, so there won't be a |
Yeah, only 1 call for /history or /queue. Looks good to me. |
What it solves
Resolves #2352
How this PR fixes it
The
/transactions
route will now redirect to either/transactions/history
or/transactions/queue
if the queue is not empty.