Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pending safes per chainId #2295

Merged
merged 5 commits into from
Aug 8, 2023
Merged

feat: pending safes per chainId #2295

merged 5 commits into from
Aug 8, 2023

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Jul 14, 2023

What it solves

Resolves #2292

How this PR fixes it

  • Stores pending Safe per chainId

How to test it

  • Create a Safe on Görli but do not wait for the tx to process
  • Switch to Polygon
  • Create a Safe on polygon in parallel

TODO

  • fix and write unit-test
  • refresh state when switching chain on Status screen

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Branch preview

✅ Deploy successful!

https://pending_safe_creation--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 14, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member

@schmanu is this ready for review?

@schmanu
Copy link
Member Author

schmanu commented Jul 27, 2023

@katspaugh No not yet.
I need to fix up the tests and write a new test for this. Switching chains while being in Safe creation also ends up in a very weird state.

@katspaugh katspaugh marked this pull request as draft July 27, 2023 09:12
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@schmanu schmanu marked this pull request as ready for review August 3, 2023 12:46
@schmanu schmanu requested a review from iamacook August 3, 2023 12:46
@francovenica
Copy link
Contributor

LGTM

@schmanu schmanu merged commit 9750cec into dev Aug 8, 2023
7 checks passed
@schmanu schmanu deleted the pending-safe-creation branch August 8, 2023 13:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Safe creation] Store pending state per chain and let users abort a stuck creation
4 participants