-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reopen QR modal in safe creation #2294
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a test that needs to be fixed but otherwise looks good to me!
Looks like the validation now doesn't run anymore in certain cases. Will have to take a look at this again. Ideally we can find a way to not trigger the validation when pressing the QR Code button. |
Yeah, In the address book test it seems that is failing becaus the "Save" button becomes clickable as soon as you write anything, and not when a valid address is in the input. |
I've switched to using RHF native |
Looks good now. The validations work fine as well. |
What it solves
Fix for #2280
How this PR fixes it
How to test it
Checklist