Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary hook #2271

Merged
merged 2 commits into from
Jul 11, 2023
Merged

fix: remove unnecessary hook #2271

merged 2 commits into from
Jul 11, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves unnecessary hook

How this PR fixes it

The TxStatusWidget no longer requires useDarkMode to set the colour of the badge. Instead it now uses the data-theme attribute.

How to test it

Create a transaction and switch between the light and dark mode. Observe the badge colour changing correctly.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Jul 11, 2023
@github-actions
Copy link

Branch preview

⏳ Deploying a preview site...

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Makes a lot of sense!

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook merged commit 21878ba into epic-tx-flow Jul 11, 2023
5 of 7 checks passed
@iamacook iamacook deleted the dark-mode-css branch July 11, 2023 13:05
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants