Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase min-width of nonce field #2270

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

iamacook
Copy link
Member

What it solves

Increase min-width of nonce field

How this PR fixes it

The "base" min-width of the nonce field has been increased to 4 characters as per design request.

How to test it

Create a transaction and observe the increased min-width of the nonce field.

Screenshots

nonce

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Jul 11, 2023
@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Branch preview

✅ Deploy successful!

https://nonce_char_width--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind if the input is a bit wider but since we have the space now, is it possible to not make it jump when the reset button appears? I believe its already absolutely positioned but somehow there is still a jump.

@iamacook iamacook merged commit da39b3d into epic-tx-flow Jul 11, 2023
7 checks passed
@iamacook iamacook deleted the nonce-char-width branch July 11, 2023 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants