Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TX flow] Batch execute fixes #2268

Merged
merged 3 commits into from
Jul 11, 2023
Merged

[TX flow] Batch execute fixes #2268

merged 3 commits into from
Jul 11, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jul 11, 2023

What it solves

Part of #2067

How this PR fixes it

  • Hide the status widget for batch executions
  • More visible warning message
  • Close the modal when submitting the transaction

How to test it

  1. Open a Safe with at least 2 fully signed transactions
  2. Go to the Queue
  3. Press Batch Execute
  4. Observe an orange warning box at the bottom
  5. Observe no Status widget
  6. Switch to mobile view and observe no status widget toggle button
  7. Execute transaction
  8. Observe the modal closes

Screenshots

Screenshot 2023-07-11 at 14 50 57

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Branch preview

⏳ Deploying a preview site...

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good but I'm not sure about entirely hiding the status widget. Perhaps we should just hide the irrelevant steps. What do you think?

@usame-algan
Copy link
Member Author

All looks good but I'm not sure about entirely hiding the status widget. Perhaps we should just hide the irrelevant steps. What do you think?

I was also thinking about that but the only relevant step is "Execute" which we already tell the user in the subtitle by saying "Execute Batch".

@iamacook
Copy link
Member

I was also thinking about that but the only relevant step is "Execute" which we already tell the user in the subtitle by saying "Execute Batch".

It seems odd without the widget as it doesn't "match" the flow. We could still show the "Execute" step. cc @liliiaorlenko (see screenshot in description)

@liliiaorlenko
Copy link

I was also thinking about that but the only relevant step is "Execute" which we already tell the user in the subtitle by saying "Execute Batch".

It seems odd without the widget as it doesn't "match" the flow. We could still show the "Execute" step. cc @liliiaorlenko (see screenshot in description)

yes I would still keep the execute step for sure, it makes sense in overall structure of transaction flow
maybe instead of "Execute batch" I would just use Batch

@usame-algan
Copy link
Member Author

yes I would still keep the execute step for sure, it makes sense in overall structure of transaction flow maybe instead of "Execute batch" I would just use Batch

I've updated the status widget messages (see PR description).

@usame-algan usame-algan merged commit 6d6859e into epic-tx-flow Jul 11, 2023
5 of 7 checks passed
@usame-algan usame-algan deleted the batch-execute branch July 11, 2023 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants