Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix network name selection in E2E #2267

Merged
merged 2 commits into from
Jul 11, 2023
Merged

chore: fix network name selection in E2E #2267

merged 2 commits into from
Jul 11, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves failing E2Es

How this PR fixes it

After aligning the names of "Goerli" on our chain config. our smoke tests stopped working as it was selecting "Görli".

This updates the smokes to match the both.

How to test it

Run the create_safe_simple.cy.js and nfts.cy.js smokes and observe them passing.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Jul 11, 2023
@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Branch preview

✅ Deploy successful!

https://fix_e2e_tests--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook marked this pull request as ready for review July 11, 2023 10:00
@iamacook
Copy link
Member Author

I'm going to merge this directly as it only concerns tests.

@iamacook iamacook merged commit f5e7f5d into dev Jul 11, 2023
7 checks passed
@iamacook iamacook deleted the fix-e2e-tests branch July 11, 2023 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants