Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Review send NFT view full width #2263

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: Review send NFT view full width #2263

merged 1 commit into from
Jul 10, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jul 10, 2023

What it solves

Part of #2067

How this PR fixes it

  • Changes the NFT view to take up the available space

How to test it

  1. Open a Safe
  2. Create an NFT transfer
  3. Observe the NFT list taking up the whole space

Screenshots

Screenshot 2023-07-10 at 17 57 47

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Jul 10, 2023

Branch preview

✅ Deploy successful!

https://nft_view--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 10, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan merged commit 089e287 into epic-tx-flow Jul 10, 2023
5 of 7 checks passed
@usame-algan usame-algan deleted the nft-view branch July 10, 2023 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants