Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable submit button for non-owners #2261

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

usame-algan
Copy link
Member

What it solves

Part of #2067

How this PR fixes it

  • Adds the non-owner check back when executing a tx

How to test it

  1. Open a Safe
  2. Create a new transaction
  3. Swich to a non-owner wallet
  4. Observe the Submit button is disabled and an error is shown
  5. Switch to signing
  6. Observe the Submit button is disabled and an error is shown
  7. Go to a fully signed tx in the queue as a non-owner
  8. Press the execute button
  9. Observe the Submit button is enabled

Screenshots

Screenshot 2023-07-10 at 17 37 01 Screenshot 2023-07-10 at 17 37 22 Screenshot 2023-07-10 at 17 37 37

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Jul 10, 2023

Branch preview

✅ Deploy successful!

https://disable_submit--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan merged commit 3e56abd into epic-tx-flow Jul 10, 2023
5 of 7 checks passed
@usame-algan usame-algan deleted the disable-submit branch July 10, 2023 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants