Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update token price tooltip #2257

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: update token price tooltip #2257

merged 1 commit into from
Jul 10, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves #2252

How this PR fixes it

This updates the token price tooltip for those with a fiat value of 0 to: "Provided values are indicative and we are unable to accommodate pricing requests for individual assets".

How to test it

Hover over the warning next to a token that has a fiat value of 0 and observe the new tooltip title.

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from schmanu July 10, 2023 10:18
@iamacook iamacook self-assigned this Jul 10, 2023
@github-actions
Copy link

github-actions bot commented Jul 10, 2023

Branch preview

✅ Deploy successful!

https://balance_tooltip--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook removed their assignment Jul 10, 2023
@francovenica
Copy link
Contributor

LGTM. The message is correct
image

@iamacook iamacook merged commit c5dd796 into dev Jul 10, 2023
6 of 7 checks passed
@iamacook iamacook deleted the balance-tooltip branch July 10, 2023 13:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change tooltip for token prices
3 participants