Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recipient title alignment #2240

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix: recipient title alignment #2240

merged 1 commit into from
Jul 6, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jul 6, 2023

What it solves

Resolves title misalignment

How this PR fixes it

The Grid within the SendToBlock has been adjusted, allowing the address to "decide" the alignment.

How to test it

  1. Create a standard transaction and observe the correct alignment of the "To" title and address.
  2. Create a Safe Apps transaction and observe the correct alignment of the "Interact with (and send n ETH to):" title and address.

Screenshots

Standard transaction:

image

Safe Apps transaction:

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from usame-algan July 6, 2023 09:29
@iamacook iamacook self-assigned this Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Branch preview

✅ Deploy successful!

https://send_to_title--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook merged commit 0e071e6 into epic-tx-flow Jul 6, 2023
7 checks passed
@iamacook iamacook deleted the send-to-title branch July 6, 2023 14:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants