Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show redefine warnings on mobile #2234

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Jul 5, 2023

What it solves

  • adds RedefineMessage to TxChecks for small screens
  • changes order of Redefine scan results and Tenderly Simulation

How to test it

  • Open app in mobile or in a small window
  • create transaction
  • observe redefine results under the "Scan for risks" box

Screenshots

Screenshot 2023-07-05 at 15 57 18

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

- adds RedefineMessage to TxChecks for small screens
- changes order of Redefine scan results and Tenderly Simulation
@schmanu schmanu requested a review from usame-algan July 5, 2023 14:03
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Branch preview

✅ Deploy successful!

https://tx_flow_mobile_redefine--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan
Copy link
Member

Can we also show the Tenderly message below the Tenderly box on mobile?

Screenshot 2023-07-05 at 16 21 42

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the Tenderly message missing on mobile it looks good 👍

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a simple and effective solution. The DOM overhead is minimal. 👍

@schmanu schmanu merged commit c9bff78 into epic-tx-flow Jul 5, 2023
7 checks passed
@schmanu schmanu deleted the tx-flow-mobile-redefine branch July 5, 2023 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants