-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Hide confirmation dialog if set via setTxFlow #2233
Conversation
Branch preview✅ Deploy successful! https://confirmation_dialog--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
We might be able to use our own confirmation dialog but we need to figure out how to do it all in one callback that we can await and throw if necessary. The previous approach of rendering another component depending on a local state didn't work with blocking the router event. |
@@ -149,7 +149,6 @@ const TxNonceForm = ({ nonce, recommendedNonce }: { nonce: number; recommendedNo | |||
readOnly, | |||
}} | |||
className={css.input} | |||
title={field.value} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This caused MUI errors because Tooltips can't also contain a title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat.
What it solves
Part of #2067
How this PR fixes it
setTxFlow
to bypass confirmation dialogHow to test it
Screenshots
Checklist