Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle relayed txs and errors in status screen #2226

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jul 4, 2023

What it solves

Resolves #2023

How this PR fixes it

  • Handles Relayed transactions in Status screen
  • Listens to the TxEvent.FAILED event in order to show an error state and message

How to test it

  1. Open a Safe
  2. Queue a transaction that would fail
  3. Execute the transaction via relayer (or any other method that will result in a TxEvent.FAILED event)
  4. Observe the Status screen changing

Screenshots

Screenshot 2023-07-04 at 16 51 27 Screenshot 2023-07-04 at 16 50 56

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Branch preview

✅ Deploy successful!

https://success_screen_ui--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan
Copy link
Member Author

Relayed transactions don't have a txHash so the stepper looks kinda empty. We could think about either hiding it or showing something else there instead of saying "Your transaction"

@usame-algan usame-algan requested a review from iamacook July 4, 2023 14:52
@usame-algan usame-algan merged commit 4ab2902 into epic-tx-flow Jul 5, 2023
5 of 7 checks passed
@usame-algan usame-algan deleted the success-screen-ui branch July 5, 2023 08:34
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants