Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide reset nonce button #2223

Merged
merged 2 commits into from
Jul 4, 2023
Merged

fix: Hide reset nonce button #2223

merged 2 commits into from
Jul 4, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jul 4, 2023

What it solves

Part of #2067

How this PR fixes it

  • Hides the reset nonce button instead of disabling it
  • Shows the value as the title when hovering

How to test it

  1. Open a Safe
  2. Create a new transaction
  3. Observe the input field being smaller
  4. Observe the reset nonce button not visible
  5. Change the nonce
  6. Observe the reset nonce button is visible

Screenshots

Screenshot 2023-07-04 at 10 41 14 Screenshot 2023-07-04 at 10 41 23 Screenshot 2023-07-04 at 10 41 35

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Branch preview

✅ Deploy successful!

https://tx_nonce_ui--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@usame-algan usame-algan merged commit f7d521e into epic-tx-flow Jul 4, 2023
7 checks passed
@usame-algan usame-algan deleted the tx-nonce-ui branch July 4, 2023 12:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants