Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: pass Redefine API URL from GitHub secrets #2218

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fix: pass Redefine API URL from GitHub secrets #2218

merged 1 commit into from
Jul 3, 2023

Conversation

katspaugh
Copy link
Member

I've added an env var but forgot to pass it in the build YML.

@github-actions
Copy link

github-actions bot commented Jul 3, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://fix_env_var--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@katspaugh
Copy link
Member Author

I've tested on the PR preview, Redefine works now.

@katspaugh katspaugh merged commit 00b9949 into dev Jul 3, 2023
7 checks passed
@katspaugh katspaugh deleted the fix-env-var branch July 3, 2023 12:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@usame-algan usame-algan usame-algan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katspaugh @usame-algan