Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] SEP #5 - Update header/widget #2213

Merged
merged 3 commits into from
Jul 13, 2023
Merged

[EPIC] SEP #5 - Update header/widget #2213

merged 3 commits into from
Jul 13, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jul 3, 2023

What it solves

Resolves missing type/staging URL for SEP #5 claiming data

How this PR fixes it

The forthcoming claiming data for SEP #5 will be tagged under user_v2. This adds the new type, as well as the staging URL.

How to test it

Open the PR deployment on a Safe that is part of the test allocation and observe the increased allocation in the header/governance app widget.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Branch preview

✅ Deploy successful!

https://sep5_type--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook removed the blocked label Jul 10, 2023
@iamacook iamacook requested a review from schmanu July 10, 2023 11:54
@iamacook iamacook changed the title fix: add type of SEP #5 claiming data [EPIC] SEP #5 - Add user_v2 type Jul 10, 2023
@iamacook iamacook marked this pull request as ready for review July 10, 2023 11:55
@iamacook iamacook changed the title [EPIC] SEP #5 - Add user_v2 type [EPIC] SEP #5 - Update header/widget Jul 11, 2023
@liliya-soroka
Copy link
Member

incorrect amount in displayed
image - https://sep5_type--walletweb.review-wallet-web.5afe.dev/home?safe=gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c

Same in my safe on prod without SEP5 allocation
image - https://app.safe.global/home?safe=gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c

Please, check that the test data is correct

@iamacook
Copy link
Member Author

incorrect amount in displayed image - https://sep5_type--walletweb.review-wallet-web.5afe.dev/home?safe=gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c

Same in my safe on prod without SEP5 allocation image - https://app.safe.global/home?safe=gor:0xC642bEc0e4f69815e89723C09caA8DAa524cAc9c

Please, check that the test data is correct

There was an issue with the test data which has now been fixed. I can see the difference with the following Safe: gor:0xAecDFD3A19f777F0c03e6bf99AAfB59937d6467b.

@liliya-soroka
Copy link
Member

Verified

@iamacook iamacook merged commit 8e32463 into dev Jul 13, 2023
6 of 7 checks passed
@iamacook iamacook deleted the sep5-type branch July 13, 2023 07:53
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants