Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] feat: use WalletConnect outside of Safe Apps #2211

Closed
wants to merge 1 commit into from
Closed

Conversation

iamacook
Copy link
Member

What it solves

Makes WalletConnect a first-class citizen

How this PR fixes it

A new WC icon in the header mounts an AppFrame, loading the WC Safe App in the background. This allows for interaction with the Safe, no longer needing to keep the WC Safe App open.

How to test it

  1. Open the Safe and connect to an EOA.
  2. Open the new WC modal by clicking on the icon on the header.
  3. Connect to another Safe or DApp via WC.
  4. You can exit the modal and navigate around the Safe, but still transact via WC.

Screenshots

The bottom Safe is connected to an EOA, whilst the top on connects via WC:

wc header

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Jun 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 30, 2023

Branch preview

✅ Deploy successful!

https://wc_widget--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member

Awesome work! And so simple!

Now let's wrap it into a browser extension, and we got ourselves a Safe Connect. 😎

@iamacook
Copy link
Member Author

As per discussion, we will close this for now but use it as reference when we tackle the roadmap item.

@iamacook iamacook closed this Jul 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
@katspaugh
Copy link
Member

For the record: I loved it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants