[WC v2] Swapping owners in the MM phone app

[francovenica]

Bug description

This issue is a leftover from RC 1.18.0

Connecting to the app with the MM phone app through WC v2 doesn't work properly:
In the top right corner it shows that the owner has changed, but when you try to execute a tx you see an error in the form. If you try to execute a tx anyways in the MM phone app is the 1st owner that is prompted to sign instead of the one you swapped to.
If the user refreshes the web app, after a while WC will reconect, but it will swap to the owner you connected in the first place.

Environment

• Browser: Chrome
• Wallet: WC v2 with MM phone app
• Chain: Any
• Env: 1.18.0

Steps to reproduce

1. You need a MM phone app with at least 2 accounts. At least 1 of them have to be owner of a safe 1/x
2. Enter in that safe and connect with WC v2 with its owner
3. Propose a transaction and send it to the queue tab
4. Open the tx in queue and see that no error popup yet
5. Switch owners in the MM phone app
6. Check that the owner has changed in the web app in the top right corner
7. Try to execute the transaction (even if the other user is not an owner, a fully signed tx should be executable with any account connected)
8. Refresh the page and check the owner connected

Expected result

No errors present in the form
In the MM phone app, it should propmt to execute the tx with the owner connected
After step 8, is expected the owner you swapped to to be connected now

Obtained result

In the form there is an error showing
When you execute, in the MM phone app it prompts the previous account to execute the tx, and not the owner you have
After step 8, the MM phone app reconnects, but with the account you used at first, and not the one you swapped into

Screenshots

The tx was executed by the previous account:

The error in the form when you swapp accounts:

The reconection:

[iamacook]

I believe this is an issue on their side: MetaMask/metamask-mobile#6655.

[liliya-soroka]

still relevant - 14.02.2024