Skip to content

Commit

Permalink
Chore: fix branch conditionals (#3782)
Browse files Browse the repository at this point in the history
  • Loading branch information
katspaugh authored May 30, 2024
1 parent a7b60f4 commit d5f5adb
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/deploy-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- uses: ./.github/workflows/build
with:
secrets: ${{ toJSON(secrets) }}
prod: ${{ github.ref == 'refs/heads/main' }}
prod: ${{ github.base_ref == 'main' }} # PRs to main are Release Candidates and must be tested with prod settings

- uses: ./.github/workflows/build-storybook

Expand All @@ -53,14 +53,14 @@ jobs:

# Staging
- name: Deploy to the staging S3
if: github.ref == 'refs/heads/main'
if: startsWith(github.ref, 'refs/heads/main')
env:
BUCKET: s3://${{ secrets.AWS_STAGING_BUCKET_NAME }}/current
run: bash ./scripts/github/s3_upload.sh

# Dev
- name: Deploy to the dev S3
if: github.ref == 'refs/heads/dev'
if: startsWith(github.ref, 'refs/heads/dev')
env:
BUCKET: s3://${{ secrets.AWS_DEVELOPMENT_BUCKET_NAME }}
run: bash ./scripts/github/s3_upload.sh
Expand Down

0 comments on commit d5f5adb

Please sign in to comment.