Fix: track hints only when popup is open

safe-global · Oct 27, 2023 · b314ca3 · b314ca3
1 parent c35bc78
commit b314ca3
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/src/components/walletconnect/WcSessionMananger/index.tsx b/src/components/walletconnect/WcSessionMananger/index.tsx
@@ -21,7 +21,7 @@ const SESSION_INFO_TIMEOUT = 2000
 const WcSessionManager = ({ sessions, uri }: WcSessionManagerProps) => {
   const { safe, safeAddress } = useSafeInfo()
   const { chainId } = safe
-  const { walletConnect, error, setError, setOpen } = useContext(WalletConnectContext)
+  const { walletConnect, error, setError, open, setOpen } = useContext(WalletConnectContext)
   const [proposal, setProposal] = useState<Web3WalletTypes.SessionProposal>()
   const [changedSession, setChangedSession] = useState<SessionTypes.Struct>()
 
@@ -120,23 +120,23 @@ const WcSessionManager = ({ sessions, uri }: WcSessionManagerProps) => {
 
   // Track errors
   useEffect(() => {
-    if (error) trackEvent({ ...WALLETCONNECT_EVENTS.SHOW_ERROR, label: error.message })
-  }, [error])
+    if (error && open) {
+      trackEvent({ ...WALLETCONNECT_EVENTS.SHOW_ERROR, label: error.message })
+    }
+  }, [error, open])
 
   //
   // UI states
   //
 
+  // Nothing to show
+  if (!open) return null
+
   // Error
   if (error) {
     return <WcErrorMessage error={error} onClose={onErrorReset} />
   }
 
-  // Session proposal
-  if (proposal) {
-    return <WcProposalForm proposal={proposal} onApprove={onApprove} onReject={onReject} />
-  }
-
   // Session info
   if (changedSession) {
     return (
@@ -147,6 +147,11 @@ const WcSessionManager = ({ sessions, uri }: WcSessionManagerProps) => {
     )
   }
 
+  // Session proposal
+  if (proposal) {
+    return <WcProposalForm proposal={proposal} onApprove={onApprove} onReject={onReject} />
+  }
+
   // Connection form (initial state)
   return <WcConnectionForm sessions={sessions} onDisconnect={onDisconnect} uri={uri} />
 }