Fix: uncaught exception in ApprovalEditor (#2674)

safe-global · Oct 23, 2023 · 77f8862 · 77f8862
1 parent 0c1896f
commit 77f8862
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/services/exceptions/ErrorCodes.ts b/src/services/exceptions/ErrorCodes.ts
@@ -55,6 +55,7 @@ enum ErrorCodes {
   _806 = '806: Failed to remove module',
   _807 = '807: Failed to remove guard',
   _808 = '808: Failed to get transaction origin',
+  _809 = '809: Failed decoding transaction',
 
   _900 = '900: Error loading Safe App',
   _901 = '901: Error processing Safe Apps SDK request',

diff --git a/src/utils/transactions.ts b/src/utils/transactions.ts
@@ -253,10 +253,16 @@ export const decodeMultiSendTxs = (encodedMultiSendData: string): BaseTransactio
     )}`
 
     // Decode operation, to, value, dataLength
-    const [, txTo, txValue, txDataBytesLength] = ethers.utils.defaultAbiCoder.decode(
-      ['uint8', 'address', 'uint256', 'uint256'],
-      ethers.utils.hexZeroPad(txDataEncoded, 32 * 4),
-    )
+    let txTo, txValue, txDataBytesLength
+    try {
+      ;[, txTo, txValue, txDataBytesLength] = ethers.utils.defaultAbiCoder.decode(
+        ['uint8', 'address', 'uint256', 'uint256'],
+        ethers.utils.hexZeroPad(txDataEncoded, 32 * 4),
+      )
+    } catch (e) {
+      logError(Errors._809, e)
+      continue
+    }
 
     // Each byte is represented by two characters
     const dataLength = Number(txDataBytesLength) * 2