fix: test, refactor, remove console.logs

safe-global · Oct 4, 2023 · 6a1edf0 · 6a1edf0
1 parent 211b5dc
commit 6a1edf0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/src/components/settings/SignerAccountMFA/index.tsx b/src/components/settings/SignerAccountMFA/index.tsx
@@ -64,15 +64,15 @@ const SignerAccountMFA = () => {
       }
 
       const hasDeviceShare = await deviceShareModule.isEnabled()
-      if (hasDeviceShare !== storeDeviceShare) {
-        if (storeDeviceShare) {
-          await deviceShareModule.createAndStoreDeviceFactor()
-        } else {
-          // Switch to password recovery factor such that we can delete the device factor
-          await mpcCoreKit.inputFactorKey(new BN(securityQuestionFactor, 'hex'))
-
-          await deviceShareModule.removeDeviceFactor()
-        }
+
+      if (!hasDeviceShare && storeDeviceShare) {
+        await deviceShareModule.createAndStoreDeviceFactor()
+      }
+
+      if (hasDeviceShare && !storeDeviceShare) {
+        // Switch to password recovery factor such that we can delete the device factor
+        await mpcCoreKit.inputFactorKey(new BN(securityQuestionFactor, 'hex'))
+        await deviceShareModule.removeDeviceFactor()
       }
     } catch (error) {
       console.error(error)

diff --git a/src/hooks/wallets/mpc/__tests__/useMPCWallet.test.ts b/src/hooks/wallets/mpc/__tests__/useMPCWallet.test.ts
@@ -156,7 +156,7 @@ describe('useMPCWallet', () => {
     it('should throw if mpcCoreKit is not initialized', () => {
       const { result } = renderHook(() => useMPCWallet())
       expect(result.current.resetAccount()).rejects.toEqual(
-        new Error('MPC Core Kit  is not initialized or the user is not logged in'),
+        new Error('MPC Core Kit is not initialized or the user is not logged in'),
       )
     })
     it('should reset an account by overwriting the metadata', async () => {

diff --git a/src/hooks/wallets/mpc/useMPCWallet.ts b/src/hooks/wallets/mpc/useMPCWallet.ts
@@ -77,16 +77,13 @@ export const useMPCWallet = (): MPCWalletHook => {
       })
 
       if (mpcCoreKit.status === COREKIT_STATUS.REQUIRED_SHARE) {
-        console.log('Share required')
         // Check if we have a device share stored
         const deviceFactor = await getWebBrowserFactor(mpcCoreKit)
         if (deviceFactor) {
-          console.log('Using device factor')
           // Recover from device factor
           const deviceFactorKey = new BN(deviceFactor, 'hex')
           await mpcCoreKit.inputFactorKey(deviceFactorKey)
         } else {
-          console.log('using password')
           // Check password recovery
           if (securityQuestions.isEnabled()) {
             setWalletState(MPCWalletState.MANUAL_RECOVERY)