fix: only display on TxEvent.PROPOSED event

src/hooks/Beamer/useBeamerNps.ts

@@ -1,10 +1,9 @@
 import { useEffect } from 'react'
 
-import { txSubscribe } from '@/services/tx/txEvents'
+import { TxEvent, txSubscribe } from '@/services/tx/txEvents'
 import { useAppSelector } from '@/store'
 import { selectCookies, CookieType } from '@/store/cookiesSlice'
 import { shouldShowBeamerNps } from '@/services/beamer'
-import { successEvents } from '@/hooks/useTxNotifications'
 
 export const useBeamerNps = (): void => {
   const cookies = useAppSelector(selectCookies)
@@ -15,20 +14,18 @@ export const useBeamerNps = (): void => {
       return
     }
 
-    const unsubFns = successEvents.map((event) => {
-      return txSubscribe(event, () => {
-        // Cannot check at the top of effect as Beamer may not have loaded yet
-        if (shouldShowBeamerNps()) {
-          // We "force" the NPS banner as we have it globally disabled in Beamer to prevent it
-          // randomly showing on pages that we don't want it to
-          // Note: this is not documented but confirmed by Beamer support
-          window.Beamer?.forceShowNPS()
-        }
+    const unsubscribe = txSubscribe(TxEvent.PROPOSED, () => {
+      // Cannot check at the top of effect as Beamer may not have loaded yet
+      if (shouldShowBeamerNps()) {
+        // We "force" the NPS banner as we have it globally disabled in Beamer to prevent it
+        // randomly showing on pages that we don't want it to
+        // Note: this is not documented but confirmed by Beamer support
+        window.Beamer?.forceShowNPS()
+      }
 
-        unsubFns.forEach((unsub) => unsub())
-      })
+      unsubscribe()
     })
 
-    return unsubFns.forEach((unsub) => unsub())
+    return unsubscribe
   }, [isBeamerEnabled])
 }

src/hooks/useTxNotifications.ts

@@ -41,12 +41,7 @@ enum Variant {
   ERROR = 'error',
 }
 
-export const successEvents = [
-  TxEvent.PROPOSED,
-  TxEvent.SIGNATURE_PROPOSED,
-  TxEvent.ONCHAIN_SIGNATURE_SUCCESS,
-  TxEvent.SUCCESS,
-]
+const successEvents = [TxEvent.PROPOSED, TxEvent.SIGNATURE_PROPOSED, TxEvent.ONCHAIN_SIGNATURE_SUCCESS, TxEvent.SUCCESS]
 
 export const getTxLink = (
   txId: string,