Skip to content

feat: change redirect behaviour after login on welcome page #6991

feat: change redirect behaviour after login on welcome page

feat: change redirect behaviour after login on welcome page #6991

Triggered via pull request November 9, 2023 11:56
@schmanuschmanu
opened #2780
Status Success
Total duration 15s
Artifacts

cla.yml

on: pull_request_target
CLAAssistant
6s
CLAAssistant
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 1 warning
SocialSignerLogin > should display Password Recovery form and display a Continue as button when login succeeds: src/components/common/SocialSigner/__tests__/SocialSignerLogin.test.tsx#L113
TypeError: socialWalletService.getSignerAddress is not a function at getSignerAddress (/home/runner/work/safe-wallet-web/safe-wallet-web/src/components/common/SocialSigner/index.tsx:82:47) at onSubmit (/home/runner/work/safe-wallet-web/safe-wallet-web/src/components/common/SocialSigner/PasswordRecovery.tsx:49:7) at state (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/react-hook-form/src/logic/createFormControl.ts:1069:19)
WalletLogin > should render connect wallet if no wallet is connected: src/components/welcome/WelcomeLogin/__tests__/WalletLogin.test.tsx#L40
TypeError: Cannot read properties of undefined (reading 'length') at length (/home/runner/work/safe-wallet-web/safe-wallet-web/src/components/welcome/WelcomeLogin/WalletLogin.tsx:18:74) at processTicksAndRejections (node:internal/process/task_queues:95:5)
CLAAssistant
The following actions uses node12 which is deprecated and will be forced to run on node16: contributor-assistant/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/